fix: filter deleted indexes in GetIndexedSegments to prevent stale segment loading [2.6]#48559
Open
XuanYang-cn wants to merge 1 commit intomilvus-io:2.6from
Open
fix: filter deleted indexes in GetIndexedSegments to prevent stale segment loading [2.6]#48559XuanYang-cn wants to merge 1 commit intomilvus-io:2.6from
XuanYang-cn wants to merge 1 commit intomilvus-io:2.6from
Conversation
…gment loading GetIndexedSegments included deleted index entries in targetIndices but skipped them in the counting loop, causing indexedFields to never equal len(targetIndices) when deleted entries existed. This made every segment appear unindexed after drop+create index cycles, forcing GetQueryVChanPositions to fall back to loading stale pre-compaction segments instead of the optimized one. pr: milvus-io#48558 See also: milvus-io#48557 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
sre-ci-robot
added
do-not-merge/need-merge-master-first
Contributor
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.6 #48559 +/- ##
==========================================
+ Coverage 76.99% 77.27% +0.28%
==========================================
Files 1700 1960 +260
Lines 262533 309561 +47028
==========================================
+ Hits 202142 239220 +37078
- Misses 53550 62808 +9258
- Partials 6841 7533 +692
🚀 New features to boost your workflow:
|
sre-ci-robot
added
low-code-coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetIndicesinGetIndexedSegments, fixing a mismatch wherelen(targetIndices)included deleted entries but the counting loop skipped themGetQueryVChanPositionsto load stale pre-compaction segments instead of the optimized onepr: #48558
issue: #48557
Signed-off-by: yangxuan xuan.yang@zilliz.com